Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandards2.0 in ClassLib instead of netcoreapp2.0 #18

Merged
merged 3 commits into from Sep 13, 2018

Conversation

@ollejacobsen
Copy link

@ollejacobsen ollejacobsen commented May 31, 2018

Target netstandards2.0 in ClassLib instead of netcoreapp2.0
Also updates AutoFixure to 4.4.0 due to the netstandards support.

Updates AutoFixure to 4.4.0 due to the netstandards support
@asser-dk
Copy link

@asser-dk asser-dk commented May 31, 2018

Perfect! I was going to make the same pull request today

@ollejacobsen
Copy link
Author

@ollejacobsen ollejacobsen commented May 31, 2018

There are two tests that are failing. But they failed for the same reason when I ran them on master so I left them untouched.

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Jun 22, 2018

Hi @ollejacobsen and @asser-dk, Do you mind telling me your use case/requirement here? Do you have to consume some existing .net framework assembly in your current application which require some framework related features and you opted .net standard? If so can you please let me know the exact framework version of your application?

Thanks for additional information.

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Jul 10, 2018

Hi @asser-dk and @ollejacobsen, Can I please get some input from your side for my query above?

Thanks!

@gregorylyons
Copy link

@gregorylyons gregorylyons commented Aug 10, 2018

@Shwetajain148 At a guess; placing logging into a library used as a dependency in a .NET framework and a core application.

@petterl
Copy link

@petterl petterl commented Aug 31, 2018

Hi @Shwetajain148, I'm in the same team as @ollejacobsen and the reason is that we have an old framework library that is ported to netstandard. This is included in other framework applications but will be included in netcore applications in the future.

We use loggly extensivly in the library currently and would love to do that in the future as well.
To have a lib targeting netstandard is a good thing since it can be consumed by both netstandard, netcore and framework projects.

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Sep 7, 2018

Hi @petterl & @gregorylyons, Thanks for your inputs here. I'm certainly going to look at this PR soon and implement the right behavior. Currently I'm working on some other ongoing issues so need some time to switch over it.

Thank you once again for being around.

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Sep 13, 2018

Tested the PR and found working fine with both .NET Core and .NET Frameworks. Merging this one.

@Shwetajain148 Shwetajain148 merged commit f548c6e into loggly:master Sep 13, 2018
@petterl
Copy link

@petterl petterl commented Sep 13, 2018

Great. When is a new release planned?

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Sep 14, 2018

@petterl, I have released the beta package containing the new changes here- https://www.nuget.org/packages/log4net-loggly/8.0.1-beta. Feel free to test this out and report us back that how it goes.

We are expecting some community feedback before publishing the final production release. Still for your question- The new production release is scheduled for the next week.

Thanks!

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Sep 20, 2018

Hey All, The new package containing .NET Standard support is in production now. Ref- https://www.nuget.org/packages/log4net-loggly/8.0.1

Thanks!

@Shwetajain148 Shwetajain148 mentioned this pull request Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.