Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Target netstandards2.0 in ClassLib instead of netcoreapp2.0 #18
Conversation
Updates AutoFixure to 4.4.0 due to the netstandards support
|
Perfect! I was going to make the same pull request today |
|
There are two tests that are failing. But they failed for the same reason when I ran them on master so I left them untouched. |
|
Hi @ollejacobsen and @asser-dk, Do you mind telling me your use case/requirement here? Do you have to consume some existing .net framework assembly in your current application which require some framework related features and you opted .net standard? If so can you please let me know the exact framework version of your application? Thanks for additional information. |
|
Hi @asser-dk and @ollejacobsen, Can I please get some input from your side for my query above? Thanks! |
|
@Shwetajain148 At a guess; placing logging into a library used as a dependency in a .NET framework and a core application. |
|
Hi @Shwetajain148, I'm in the same team as @ollejacobsen and the reason is that we have an old framework library that is ported to netstandard. This is included in other framework applications but will be included in netcore applications in the future. We use loggly extensivly in the library currently and would love to do that in the future as well. |
|
Hi @petterl & @gregorylyons, Thanks for your inputs here. I'm certainly going to look at this PR soon and implement the right behavior. Currently I'm working on some other ongoing issues so need some time to switch over it. Thank you once again for being around. |
|
Tested the PR and found working fine with both .NET Core and .NET Frameworks. Merging this one. |
|
Great. When is a new release planned? |
|
@petterl, I have released the beta package containing the new changes here- https://www.nuget.org/packages/log4net-loggly/8.0.1-beta. Feel free to test this out and report us back that how it goes. We are expecting some community feedback before publishing the final production release. Still for your question- The new production release is scheduled for the next week. Thanks! |
|
Hey All, The new package containing .NET Standard support is in production now. Ref- https://www.nuget.org/packages/log4net-loggly/8.0.1 Thanks! |
Target netstandards2.0 in ClassLib instead of netcoreapp2.0
Also updates AutoFixure to 4.4.0 due to the netstandards support.