Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to set tag via constructor #2

Closed
wants to merge 2 commits into from

Conversation

@varshneyjayant
Copy link

@varshneyjayant varshneyjayant commented Aug 12, 2015

No description provided.

@varshneyjayant
Copy link
Author

@varshneyjayant varshneyjayant commented Aug 12, 2015

@tony19 I have created a fresh pull request. Hope, this looks better.

@mostlyjason
Copy link

@mostlyjason mostlyjason commented Aug 20, 2015

Cool hopefully we can get this merged

@tony19

This comment has been minimized.

Now that the whitespace has been corrected, I can actually see what you've changed :)

Unfortunately, I don't see enough value in the change. Why not just use the existing API (setTags)?

@varshneyjayant
Copy link
Author

@varshneyjayant varshneyjayant commented Aug 31, 2015

Closing this PR as there is not any major change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.