Skip to content

/ loggly-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper retrofit2 async execution #6

Open
wants to merge 4 commits into
base: master
from
Open

Use proper retrofit2 async execution #6

wants to merge 4 commits into from

Conversation

@linakis
Copy link
Contributor

@linakis linakis commented Jan 8, 2018

Use the new asynchronous Call instead of the old Callback way
@linakis
Use proper retrofit2 async execution
Loading status checks…
41f8b49
@linakis
Copy link
Contributor Author

@linakis linakis commented Jan 9, 2018

In Retrofit 2 the Interface definition is the same for synchronous and asynchronous requests. It's up to the execution Call method execute for synchronous and enqueue for async. As opposed to Retrofit 1.9 Interface definition containing the Callback to signal asynchronous execution.
@linakis
Copy link
Contributor Author

@linakis linakis commented Apr 27, 2018

Any news on this?
@linakis
Copy link
Contributor Author

@linakis linakis commented May 14, 2018 •
edited

@tony19 any updates on this pull request? it's pretty straightforward. Since retrofit 2.2.0 proguard complaints and production release fails.
@anthony-skr
Copy link

@anthony-skr anthony-skr commented Aug 23, 2018

hey @linakis thank you for the patch. Saved my day 👍 too bad loggly does not maintain this library anymore.
@linakis
Copy link
Contributor Author

@linakis linakis commented Aug 26, 2018

@anthony-skr glad I helped. I've actually made some enhancements for a project I'm currently working on and probably will publish them once I'm sure they are stable.
linakis added 3 commits Oct 10, 2018
@linakis
Sanitize tags from invalid characters
51d44ee
@linakis
sanitize tags from invalid characters
97bdc0d
@linakis
Merge pull request #1 from linakis/tags_sanitize
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4cb819b 
sanitize tags from invalid characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@linakis @anthony-skr
You can’t perform that action at this time.