Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower deployment #4

Closed
ppcano opened this issue Sep 23, 2014 · 21 comments
Closed

Bower deployment #4

ppcano opened this issue Sep 23, 2014 · 21 comments

Comments

@ppcano
Copy link

@ppcano ppcano commented Sep 23, 2014

would it be possible that the library can be deployed with bower?

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Sep 24, 2014

Yeah we can work on getting it up on bower

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Sep 24, 2014

Looks like someone added already. Have you looked at using one of these? http://bower.io/search/?q=loggly

@ppcano
Copy link
Author

@ppcano ppcano commented Sep 25, 2014

@mostlyjason , this search only shows two angular packages angular-loggly and angular-loggly-logger, instead of this repo.

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Sep 25, 2014

Yeah I was hoping those might work since they are wrappers for this
library and already include it. It sounds like you prefer this version
without angular?

On 9/24/2014 10:59 PM, Pepe Cano wrote:

@mostlyjason https://github.com/mostlyjason , this search only shows
two angular packages angular-loggly
https://github.com/GoAugust/angular-loggly and angular-loggly-logger
https://github.com/ajbrown/angular-loggly-logger, instead of this repo.


Reply to this email directly or view it on GitHub
#4 (comment).

@ppcano
Copy link
Author

@ppcano ppcano commented Sep 25, 2014

Yes, this repository

El 25/09/2014, a las 08:31, Jason Skowronski notifications@github.com
escribió:

Yeah I was hoping those might work since they are wrappers for this
library and already include it. It sounds like you prefer this version
without angular?

On 9/24/2014 10:59 PM, Pepe Cano wrote:

@mostlyjason https://github.com/mostlyjason , this search only shows
two angular packages angular-loggly
https://github.com/GoAugust/angular-loggly and angular-loggly-logger
https://github.com/ajbrown/angular-loggly-logger, instead of this repo.


Reply to this email directly or view it on GitHub
<#4 (comment)
.


Reply to this email directly or view it on GitHub
#4 (comment).

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Oct 3, 2014

@ppcano We have added a new package loggly-jslogger. You can now use this package to deploy Loggly's jslogger using Bower.

@ppcano
Copy link
Author

@ppcano ppcano commented Oct 4, 2014

@psquickitjayant, although the package is available for bower import, I missed a bower file which manage the library release version.

Currently the library is importing as:

    "loggly-jslogger": "latest",

In this case, any new release may automatically be updated and it may break the loggly app functionality.

Please, may you manage the loggly-jslogger release process.

@ppcano
Copy link
Author

@ppcano ppcano commented Jan 8, 2015

@psquickitjayant ping.

May the bower.json file be added to the repository including the current loggly-jslogger version.

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Jan 8, 2015

@ppcano Sure, I will add it.

@barlindhaug
Copy link

@barlindhaug barlindhaug commented Feb 25, 2015

You need to git tag your releases to get a versioned bower dependency.

Right now I have to use

"loggly-jslogger": "*"

instead of

"loggly-jslogger": "1.1.0"
@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Jul 23, 2015

@barlindhaug if you see latest package, it has the version.

@ppcano
Copy link
Author

@ppcano ppcano commented Aug 3, 2015

@psquickitjayant, setup the version on the bower.json file does NOT work

    "loggly-jslogger": "2.0.0",

As @barlindhaug commented, it could be that you need to git tag your releases.

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Aug 3, 2015

@ppcano You are right, I forgot to do that. I will take care from my next release. I am making few more changes in the library. I will make sure to tag the commit.

@davidgovea
Copy link

@davidgovea davidgovea commented Aug 17, 2015

+1 for tagging releases, "loggly-jslogger": "*" makes me uneasy.
👍

"loggly-jslogger": "#c293114921" works in the meantime

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Aug 18, 2015

@mostlyjason this can be closed as the library is on Bower with versions tagged.

@davidgovea
Copy link

@davidgovea davidgovea commented Aug 18, 2015

@psquickitjayant @mostlyjason I see no versions tagged.

Here is the output from "bower info loggly-jslogger" ... No versions available.

% bower info loggly-jslogger 
bower not-cached    git://github.com/loggly/loggly-jslogger.git#*
bower resolve       git://github.com/loggly/loggly-jslogger.git#*
bower checkout      loggly-jslogger#master
bower resolved      git://github.com/loggly/loggly-jslogger.git#c293114921

{
  name: 'loggly-jslogger',
  homepage: 'https://github.com/loggly/loggly-jslogger',
  description: 'A Javascript client to send logs to Loggly.',
  main: 'src/loggly.tracker.js',
  keywords: [
    'loggly-jslogger',
    'jslogger',
    'loggly',
    'log'
  ],
  authors: [
    'Loggly'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

No versions available.
@davidgovea
Copy link

@davidgovea davidgovea commented Aug 18, 2015

From bower's bower.json docs

version
String
Deprecated. Use git or svn tags instead. This field is ignored by Bower.

@davidgovea
Copy link

@davidgovea davidgovea commented Sep 9, 2015

ping ping - would love a proper release!

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Sep 10, 2015

@davidgovea I will update today :)

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Sep 11, 2015

@davidgovea @ppcano @sirsgriffin @barlindhaug

Proper release tags are pushed in repo. You can see the versions now with bower info loggly-jslogger

$ bower info loggly-jslogger
bower loggly-jslogger#*         cached git://github.com/loggly/loggly-jslogger.git#3.0.0
bower loggly-jslogger#*       validate 3.0.0 against git://github.com/loggly/loggly-jslogger.git#*

{
  name: 'loggly-jslogger',
  homepage: 'https://github.com/loggly/loggly-jslogger',
  version: '3.0.0',
  description: 'A Javascript client to send logs to Loggly.',
  main: 'src/loggly.tracker.js',
  keywords: [
    'loggly-jslogger',
    'jslogger',
    'loggly',
    'log'
  ],
  authors: [
    'Loggly'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

Available versions:
  - 3.0.0
  - 2.0.0
You can request info for a specific version with 'bower info loggly-jslogger#<version>'
@davidgovea
Copy link

@davidgovea davidgovea commented Sep 15, 2015

@psquickitjayant thank you!

also, thanks for getting full-on tags implemented recently 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.