Skip to content

/ loggly-jslogger

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag support #25

Merged
merged 4 commits into from Jul 24, 2015
Merged

Tag support #25

merged 4 commits into from Jul 24, 2015

Conversation

@varshneyjayant
Copy link
Contributor

@varshneyjayant varshneyjayant commented Jul 22, 2015

Removed tracking pixel and added async XMLHttpRequest
varshneyjayant and others added 4 commits Jul 20, 2015
@varshneyjayant
Send requests through XMLHttpRequest
0896755
@varshneyjayant
Fixed indentation
edc9d5a
@varshneyjayant
Fixed indentation
c5daf79
Jayant Varshney
Added minified version
4b01c2d
This was referenced Jul 22, 2015
Closed
Closed
@varshneyjayant varshneyjayant mentioned this pull request Jul 22, 2015
Closed
@vhalbwachs
Copy link
Contributor

@vhalbwachs vhalbwachs commented Jul 22, 2015

If we use ajax instead of a tracking pixel, I think we're going to run into issues with CORS. Have you tested this on a site that isn't hosted on Loggly's domain?
@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Jul 22, 2015

Yeah CORS headers are live now. I believe they tested but @psquickitjayant can confirm.
@varshneyjayant
Copy link
Contributor Author

@varshneyjayant varshneyjayant commented Jul 23, 2015

@vhalbwachs I have tested it with "content-type:text/plain" and working fine. sends message to loggly and the logs are parsed as JSON logs in Loggly dashboard.

send "content-type:application/json" throws the 405 dues to CORS but may be we can avoid it using text/plain
This was referenced Jul 23, 2015
Closed
Closed
@mostlyjason mostlyjason mentioned this pull request Jul 23, 2015
Open
@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Jul 24, 2015

@vhalbwachs reminder to merge when you are done reviewing
vhalbwachs added a commit that referenced this pull request Jul 24, 2015
@vhalbwachs
Merge pull request #25 from psquickitjayant/tag-support
b185c16 
Tag support
@vhalbwachs vhalbwachs merged commit b185c16 into loggly:master Jul 24, 2015
@varshneyjayant
Copy link
Contributor Author

@varshneyjayant varshneyjayant commented Jul 24, 2015

@mostlyjason you will need to upload the latest scripts on cloudfront.
@selurvedu
Copy link

@selurvedu selurvedu commented Aug 4, 2015

👍
@mostlyjason I'm waiting for an updated version on Cloudfront. Please update the script ASAP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@varshneyjayant @vhalbwachs @mostlyjason @selurvedu
You can’t perform that action at this time.