Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Proxy domain support #27
Conversation
| 'logglyKey': '8c518f97-e3e0-4bfb-a8ed-582d084a5289', | ||
| 'sendConsoleErrors' : true, | ||
| 'tag' : 'javascript-logs', | ||
| 'useDomainProxy' : true |
mostlyjason
Jul 31, 2015
Contributor
Why not just use the domain proxy if it's not null? Wouldn't it be simpler to have one variable instead of two?
+_LTracker.push({
- 'logglyKey': '8c518f97-e3e0-4bfb-a8ed-582d084a5289',
- 'sendConsoleErrors' : true,
- 'tag' : 'javascript-logs',
- 'domainProxy' : 'loggly.mydomain.com'
+});
Why not just use the domain proxy if it's not null? Wouldn't it be simpler to have one variable instead of two?
+_LTracker.push({
- 'logglyKey': '8c518f97-e3e0-4bfb-a8ed-582d084a5289',
- 'sendConsoleErrors' : true,
- 'tag' : 'javascript-logs',
- 'domainProxy' : 'loggly.mydomain.com'
+});
varshneyjayant
Aug 3, 2015
Author
Contributor
Are we supporting them to use any domain? We are currently appending /loggly to their current domain. Like
inputUrl = window.location.host + '/loggly' + '/input/token...;
Also, we have give the example for the same in server configuration.
Are we supporting them to use any domain? We are currently appending /loggly to their current domain. Like
inputUrl = window.location.host + '/loggly' + '/input/token...;
Also, we have give the example for the same in server configuration.
mostlyjason
Aug 3, 2015
Contributor
Ahh thanks for explaining! That seems fine too. If someone wants to add other domains they can do it in another PR.
Ahh thanks for explaining! That seems fine too. If someone wants to add other domains they can do it in another PR.
No description provided.