Skip to content

/ loggly-jslogger

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different tags on each log statement #35

Closed
wants to merge 2 commits into from
+26 −2
Closed

Allow different tags on each log statement #35

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d49a02f
Allow different tags on each log statement
Dec 3, 2015
5e307ed
Add documentation of mutable tags feature
Dec 4, 2015
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Allow different tags on each log statement

  • Loading branch information
Bradley Portnoy
Bradley Portnoy committed Dec 3, 2015
commit d49a02fd28913eb67d63d9c8bb48ce9d3e27733b
15 src/loggly.tracker.js
View file
Open in desktop
@@ -27,8 +27,15 @@
}

function setTag(tracker, tag){
tracker.tag = tag;
}
tracker.tag = tag;
if (tracker.mutableTags) {

This comment has been minimized.

Sign in to view
@mostlyjason

mostlyjason Dec 8, 2015
Contributor

It seems this won't work if they initialize the library with mutableTags=false and tag=some value. We want to allow it to set during initialization.
setInputUrl(tracker);
}
}

function setMutableTags(tracker) {
tracker.mutableTags = true;
}

function setDomainProxy(tracker, useDomainProxy){
tracker.useDomainProxy = useDomainProxy;
@@ -118,6 +125,10 @@
if(data.sendConsoleErrors !== undefined) {
setSendConsoleError(self, data.sendConsoleErrors);
}

if (data.mutableTags) {
setMutableTags(self);
}

if(data.tag) {
setTag(self, data.tag);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.