Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack trace onerror when error object is available #46

Merged
merged 1 commit into from Aug 7, 2017

Conversation

@apackin
Copy link
Contributor

@apackin apackin commented Jul 17, 2017

#24

Most browsers now support the Error object as a 5th parameter to onerror. PR uses the error object to include a stack trace as per the issue above.

@fastfrwrd
Copy link

@fastfrwrd fastfrwrd commented Jul 17, 2017

This would be pretty useful for us, and I like the simplicity of it. A more cross-browser solution would turn out to be pretty involved: https://blog.sentry.io/2016/01/04/client-javascript-reporting-window-onerror.html

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented Jul 17, 2017

Thanks for the suggestion! We will review this next time we do an update of the library.

@mostlyjason mostlyjason merged commit 67507b1 into loggly:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.