Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Sync package version #48
Merged
Conversation
.gitignore
Outdated
| @@ -1,7 +1,5 @@ | |||
| /dist | |||
Shwetajain148
Aug 25, 2017
Author
Contributor
dist directory does not exist in our library so removing it.
dist directory does not exist in our library so removing it.
mostlyjason
Aug 25, 2017
Contributor
I think that folder is where the distribution files are usually placed. For example the min in the map files might be generated in when running npm build dist or some similar command. Also, what happened to generating a file for the latest version?
I think that folder is where the distribution files are usually placed. For example the min in the map files might be generated in when running npm build dist or some similar command. Also, what happened to generating a file for the latest version?
Shwetajain148
force-pushed the
Shwetajain148:Sync-package-version
branch
from
331dc4e
to
88ba8ec
| }, | ||
| main: { | ||
| files: [{ | ||
| src: 'src/loggly.tracker.js', | ||
| dest: 'src/loggly.tracker-' + packageJson.version + '.min.js' | ||
| dest: 'dist/loggly.tracker-' + packageJson.version + '.min.js' | ||
| }] | ||
| } | ||
| } |
Shwetajain148
Aug 30, 2017
Author
Contributor
@mostlyjason I have changed the path of min and map file so that they can be created in the /dist folder.
@mostlyjason I have changed the path of min and map file so that they can be created in the /dist folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I have upgraded the package version to
2.2.1inpackage.jsonfile same as the published npm package version so that on deploying it on the CDN, the version will remain in sync in all places.Ref: https://www.npmjs.com/package/loggly-jslogger