Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support special characters readability #54
Merged
Conversation
| @@ -155,7 +164,11 @@ | |||
| //creating an asynchronous XMLHttpRequest | |||
| var xmlHttp = new XMLHttpRequest(); | |||
| xmlHttp.open('POST', this.inputUrl, true); //true for asynchronous request | |||
| xmlHttp.setRequestHeader('Content-Type', 'text/plain'); | |||
| if (tracker.useUtfEncoding === true) { | |||
psamit
Aug 2, 2018
useUtfEncoding is already a boolean so no need to check with true, false or undefined.
data.useUtfEncoding for true and !data.useUtfEncoding for false or undefined will be sufficient here.
useUtfEncoding is already a boolean so no need to check with true, false or undefined.
data.useUtfEncoding for true and !data.useUtfEncoding for false or undefined will be sufficient here.
psamit
Aug 2, 2018
Changes looks good to me.
Changes looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi, In this PR, I have added a new flag variable which is configurable and will include the
charset=utf-8property in therequest header. This will enable the better readability of special characters being send in the log events.This has been tested completely and ready to merge. @psamit can you please review.
Thanks!