Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update request future (#1) #2
Conversation
* Update requirements.txt * Update handlers.py deprecate 'background_callback', use hooks
| @@ -9,10 +9,12 @@ | |||
| session = FuturesSession() | |||
|
|
|||
|
|
|||
| def bg_cb(sess, resp): | |||
|
|
|||
| def bg_cb(resp, *args, **kwargs): | |||
lancondrej
Jan 2, 2019
I prefer to rename it to response_hook because it is not background callback anymore.
I prefer to rename it to response_hook because it is not background callback anymore.
wangsha
Jan 2, 2019
Author
updated
updated
| @@ -2,4 +2,4 @@ coverage==3.7.1 | |||
| flake8==2.1.0 | |||
| mock==1.0.1 | |||
| nose==1.3.0 | |||
| requests-futures==0.9.4 | |||
| requests-futures>=0.9.9 | |||
lancondrej
Jan 2, 2019
Please change this dependency also in setup.py
Please change this dependency also in setup.py
wangsha
Jan 2, 2019
Author
updated
updated
jerson00
Nov 12, 2019
waiting for this merge, any update?
waiting for this merge, any update?
update requirements
rename background callback (bg_cp) to `response_hook`
* Update requirements.txt * Update handlers.py deprecate 'background_callback', use hooks * update setup.py package requirement rename background callback to response_callback
|
It would be great if this could be merged in as this deprecation warning is producing more logs than my application itself. |
|
+1 it is outright broken right now because of this issue. I can't even install the package anymore |
|
|
Any update about this??? |
|
These changes are included in #7. Closing this. |
latest request_future package is deprecating
background_callbackmethod in favour ofhooks.the warning message itself is generating a lot of logs.
update the method solves the problem.
Warning messages
Issue fixed