Skip to content

/ muskrat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy connections #2

Merged
merged 2 commits into from Aug 5, 2016
Merged

Lazy connections #2

merged 2 commits into from Aug 5, 2016

Commits on May 13, 2015

  1. Now lazy-loading s3 connection and s3 buckets. 

    Making these newtork calls proactively in our constructors is not a good
practice. Constructors should only configure the object for use and NOT
actually instantiate non-config object properties.

Perfect case for lazy-loading is testing. Unless the object is heavily
mocked these network calls would 1) require a network connection for
testing even if the object is only instanted in the test and not used
and 2) slow down tests due to network calls.
    Scott Griffin
    Scott Griffin committed May 13, 2015
    60be4fc

  2. Made version a property of the actual module. 

    Updated setup.py to use this version property so there is only one
source of truth.
    Scott Griffin
    Scott Griffin committed May 13, 2015
    d0bd7de
You can’t perform that action at this time.