Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

producer: Add host='' to connect_s3 for SigV4 #6

Merged
merged 1 commit into from Feb 4, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -88,7 +88,7 @@ def __init__(self, **kwargs):
@property
def s3conn(self):
if self._s3conn is None:
self._s3conn = boto.connect_s3( self.config.s3_key, self.config.s3_secret )
self._s3conn = boto.connect_s3( self.config.s3_key, self.config.s3_secret, host=self.config.s3_host )
return self._s3conn

@property
@@ -23,6 +23,8 @@

TEST_KEY_PREFIX = 'Muskrat.Producer'

boto.config.add_section('s3')
boto.config.set('s3', 'use-sigv4', 'True')

class TestProducerBase( unittest.TestCase ):

@@ -70,7 +72,7 @@ class TestS3Producer( TestProducerBase ):

def setUp(self):
super( TestS3Producer, self ).setUp()
self.conn = boto.connect_s3( config.s3_key, config.s3_secret )
self.conn = boto.connect_s3( config.s3_key, config.s3_secret, host=config.s3_host )
self.bucket = self.conn.get_bucket( config.s3_bucket )
self.key += '.Test.S3Producer'

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.