Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Recommend changing the signature of common.loggly to accept only one callback. #32
Comments
|
Hi @blyork, Thanks for your input in the callback error, I really appreciate it. Since the callback issue was resolved, do you mind closing this issue? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As stated in Issue #31, I recommend changing common.loggy's signature so that it only accepts a single callback function. The first argument will be an error/null and the later arguments will be what is returned. I do not believe this will cause issues to dependent third-party libraries since it is not exported as part of require('node-loggly-bulk'). I believe this will lead to less confusion in the future if this function is modified or used.
Please let me know what you think.