Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed on error code undefined #35

Closed
crostine opened this issue Feb 19, 2018 · 4 comments
Closed

Failed on error code undefined #35

crostine opened this issue Feb 19, 2018 · 4 comments

Comments

@crostine
Copy link

@crostine crostine commented Feb 19, 2018

Hi

My loggly account is nolonger active but the code tries to connect, and im getting the error printed to console in this file

it tries to print a statuscode which is unavailable in this function.

I also think the message would be alot better if it didnt just say "failed on error code x", but said "connection failed: code x" or something. the code didnt really fail on the error code lol

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Feb 27, 2018

Hi @crostine, I have recently changed the error retrying mechanism in the library which overcomes some issues. The new release is currently in beta so it would be great if you can test the new beta version and let me know if you still face any issue. Once I hear back from the community that the new beta version works well, I will go ahead and publish the production release.

You can install beta package using the below command:

npm install winston-loggly-bulk@beta

Thanks!

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Jun 22, 2018

Hi @crostine, Just wanted to follow up regarding your issue, are your still seeing any error? If not, then can you please close this out?

Thanks!

@crostine
Copy link
Author

@crostine crostine commented Jun 22, 2018

I don't know, I have removed loggly all together from the system.

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Aug 1, 2018

Hi @crostine, From the time you raised this issue, some bug fixes have been made which improved the library experience and I have considered your points and modified the console messages. Since this has already been resolved, I'm going ahead and closing this issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.