Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Clear all open interval and resolve callback error #15
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@mchaudhary @mostlyjason, I looked at the PR #14 and used the clearInterval() in our library to clear open interval for sendBufferdLogstoLoggly() function but using clearInterval() function only for buffer function did not help to overcome the callback issue. I used the clearInterval() function for both sendBulkLogs() and sendBufferdLogstoLoggly() functions then the callback error was removed. I ran the application continue for 30 minutes but the error did not occur. Before it was occurring in less than a minute.
I tested in below scenarios:
In both Bulk and Input mode with below conditions-
(a) Sending a single event (Worked Fine)
(b) Sending events in a loop (Worked Fine)
(c) Sending events continuous in a loop at a specific interval (Worked Fine)
In Network Outage case. (Worked Fine)
This PR will resolve the issue loggly/winston-loggly-bulk#13
Please review.