Skip to content

/ node-loggly-bulk

forked from winstonjs/node-loggly
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling syntax error while parsing HTML response #18

Merged
merged 2 commits into from Nov 7, 2017
+8 −4
Merged

Handling syntax error while parsing HTML response #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad14040
Handling syntax error while parsing HTML response
Sep 19, 2017
f4a0ad2
Log non 200 status code and message
Nov 2, 2017
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Handling syntax error while parsing HTML response

  • Loading branch information
Shweta Jain
Shweta Jain committed Sep 19, 2017
commit ad1404027f79b127db80f3b5f2d58c83a0bf0d49
10 lib/loggly/client.js
View file
Open in desktop
@@ -185,10 +185,12 @@ Loggly.prototype.log = function (msg, tags, callback) {

common.loggly(logOptions, callback, function (res, body) {
try {
var result = JSON.parse(body);
self.emit('log', result);
if (callback) {
callback(null, result);
if(body && res.statusCode.toString() === '200'){

This comment has been minimized.

Sign in to view
@mchaudhary

mchaudhary Oct 31, 2017

We should check for non 200 code and log the message.

This comment has been minimized.

Sign in to view
@Shwetajain148

Shwetajain148 Nov 2, 2017
Author

@mchaudhary, Here if the returned response code is 200 then the body contains {"response" : "ok"} which then get parsed normally. Now If the returned response code is other than 200 and in HTML format as I created a scenario in which I was getting status code 503 "Service Unavailable" then the library breaks to parse the HTML format.

I am not able to check with other server error codes like 500, 501 and 504 etc to see in what format they are returning the response and other error codes in 400 series like I tested with 403(wrong token) and 404(Not found) but in both the cases the control did not come to parse the body object and there was nothing in the body.

In the else part, I am also printing the error code with the error message.
var result = JSON.parse(body);
self.emit('log', result);
if (callback) {
callback(null, result);
}
}
}
catch (ex) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.