New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bulk messages to be passed as an array #21

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
4 participants
@MauriceButler

MauriceButler commented Oct 3, 2017

This PR allows for the previous bulk logging functionality from winstonjs/node-loggly which is relied on by bunyan-loggly.

The PR will allow bunyan-loggly to switch from winstonjs/node-loggly to node-loggly-bulk as per MauriceButler/bunyan-loggly#13

@mostlyjason

This comment has been minimized.

Show comment
Hide comment
@mostlyjason

mostlyjason Oct 3, 2017

@MauriceButler thanks for the effort you put into this! I have added a task to our team's backlog to test this. We have a couple issues in the queue ahead of this one but we should be able to test it in the next couple weeks.

mostlyjason commented Oct 3, 2017

@MauriceButler thanks for the effort you put into this! I have added a task to our team's backlog to test this. We have a couple issues in the queue ahead of this one but we should be able to test it in the next couple weeks.

@Shwetajain148

This comment has been minimized.

Show comment
Hide comment
@Shwetajain148

Shwetajain148 Oct 18, 2017

Collaborator

@mchaudhary @mostlyjason I have tested it. The PR seems good to me.

Collaborator

Shwetajain148 commented Oct 18, 2017

@mchaudhary @mostlyjason I have tested it. The PR seems good to me.

@mchaudhary mchaudhary merged commit f3004b8 into loggly:master Oct 19, 2017

@MauriceButler MauriceButler deleted the MauriceButler:support-bulk branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment