@mchaudhary@mostlyjason, At this point, if we are using the search functionality of our library like- (In our app.js file)
client.search('foo', function (err, results) {
console.dir(results.events);
});
Then the library does not set the bufferOptions object and when the library tries to access the bufferOptions.retriesInMilliSeconds property, an error is thrown so I put this check to enter into this block only when the bufferOptions object is set and has some value.
@mchaudhary@mostlyjason The same condition lies here too. I put this check to store the logs only when the bufferOptions object is set and containing the value for retriesInMilliSeconds and size otherwise this code line will throw an error.
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
Learn more.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
You can always update your selection by clicking Cookie Preferences at the bottom of the page.
For more information, see our Privacy Statement.
Essential cookies
We use essential cookies to perform essential website functions, e.g. they're used to log you in.
Learn more
Always active
Analytics cookies
We use analytics cookies to understand how you use our websites so we can make them better, e.g. they're used to gather information about the pages you visit and how many clicks you need to accomplish a task.
Learn more
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace timespan with Moment and remove security warnings #22
Replace timespan with Moment and remove security warnings #22
Changes from all commits
05bd5f4File filter...
Jump to…
Shwetajain148Oct 10, 2017
Author
@mchaudhary @mostlyjason, At this point, if we are using the search functionality of our library like- (In our app.js file)
Then the library does not set the bufferOptions object and when the library tries to access the bufferOptions.retriesInMilliSeconds property, an error is thrown so I put this check to enter into this block only when the bufferOptions object is set and has some value.
Shwetajain148Oct 10, 2017
Author
@mchaudhary @mostlyjason The same condition lies here too. I put this check to store the logs only when the bufferOptions object is set and containing the value for retriesInMilliSeconds and size otherwise this code line will throw an error.