Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added code to retry on server errors #23
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@mchaudhary @mostlyjason In this PR, I have implemented the code to store the logs before sending in a backup array when the final JSON event is ready to send and then call a function which will call the sendBulkLogs() and sendLogs() function respectively in case of Bulk and Input mode.
The approach I am following is to retry sending the logs from the backup array maximum 5 times when there is a server error and if the counter reaches to 5 then it will not retry anymore.
Currently, I am seeing some issues and doing testing of the implemented code so I need some time to complete this task.