Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Resolve TypeError for bunyan-loggly #26
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@mchaudhary @mostlyjason The issue #10 is related to bunyan-loggly library in which when we log any message then it comes in the array form and when it goes to calculate the byte length, it breaks. But in our node-loggly-bulk library when we log the data it comes in the string form and then we calculate the byte length of the log message using Buffer.byteLength() method without any error so it is not breaking with our library.
In this PR, I used the JSON.stringify() method to calculate the byte length of the log message after converting it into a JSON string. This does not change anything in the log and passes in all scenarios like if we pass a JSON object or a string or if the log comes in the array form.
I have checked this with bunyan-loggly, node-loggly-bulk and winston-loggly-bulk libraries and everything looked fine to me.