Skip to content

/ node-loggly-bulk

forked from winstonjs/node-loggly
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #31 #33

Closed
wants to merge 1 commit into from
Closed

Fix for Issue #31 #33

wants to merge 1 commit into from

Conversation

@blyork
Copy link

@blyork blyork commented Jan 8, 2018

Fix for Issue #31.
Benjamin York
Prevented callback and success from being called in one call to commo…
Unverified
No user is associated with the committer email.
Learn about signing commits
a6cb48f 
…n.loggly.
This was referenced Jan 15, 2018
Open
Closed
@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Jan 16, 2018

Hi @blyork, First of all, thank you for looking into this issue and giving your time on that to debug the library. I tested your code at my end in a continue event logging environment and after successful logging of near about 2 hours I could see the same callback error in the library.

cc: @mostlyjason
@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Jun 22, 2018

Hi @blyork, The same fix was made in the library and the callback issue was also resolved. Can you please close this PR?

Thanks!
@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Aug 1, 2018

Since this has already been handled, closing this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@blyork @Shwetajain148
You can’t perform that action at this time.