Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add new flag for network errors #39
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As per the current scenario, the library writes the networks errors on console which sometimes pollute the other important logs when the numbers are so high.
In this PR, I have made the error writing to
falseby default and added the new flag variable whose value can be set from the main application file. This variable basically allow the user to set the default value to true which will starts printing the errors on console. So if any user wants those error logs then he can set the value totrueeasily.Note: This PR is also related to loggly/winston-loggly-bulk#41 so merging both is required to work this feature.