Add headers['X-LOGGLY-TAG'] property into the request header only when the logging mode is Bulk and headers['X-LOGGLY-TAG'] contains some value. This will prevent logs sending from the undefined tag name.
method: method,
headers: isBulk ? {} : headers||{},// Set headers empty for bulk
proxy: proxy
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
Learn more.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
You can always update your selection by clicking Cookie Preferences at the bottom of the page.
For more information, see our Privacy Statement.
Essential cookies
We use essential cookies to perform essential website functions, e.g. they're used to log you in.
Learn more
Always active
Analytics cookies
We use analytics cookies to understand how you use our websites so we can make them better, e.g. they're used to gather information about the pages you visit and how many clicks you need to accomplish a task.
Learn more
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle undefined tags #40
Handle undefined tags #40
Changes from all commits
2d4ef58File filter...
Jump to…
Shwetajain148Jul 23, 2018
Author
Set the headers['X-LOGGLY-TAG'] property only when we have some actual tag defined into the tag array not undefined.
Shwetajain148Jul 23, 2018
Author
Calculate the tag's length only when tag actually has some value otherwise return.
Shwetajain148Jul 23, 2018
Author
Add headers['X-LOGGLY-TAG'] property into the request header only when the logging mode is Bulk and headers['X-LOGGLY-TAG'] contains some value. This will prevent logs sending from the undefined tag name.