Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure `request` >= 2.83.0 #41

Open
wants to merge 1 commit into
base: master
from

Conversation

@MatthewHerbst
Copy link

@MatthewHerbst MatthewHerbst commented Dec 3, 2018

Versions of request before 2.83.0 are susceptible to a ReDoS attack via it's dependency tough-cookie. Version 2.83.0 of request upgrades the version of touch-cookie to one that is no longer susceptible to the attack.

Vulnerability advisory:
https://www.npmjs.com/advisories/525

request CHANGELOG:
https://github.com/request/request/blob/master/CHANGELOG.md#v2830-20170927

Versions of `request` before 2.83.0 are susceptible to a ReDoS
attack via it's dependency `tough-cookie`. Version 2.83.0 of
`request` upgrades the version of `touch-cookie` to one that is no
longer susceptible to the attack.

Vulnerability advisory:
https://www.npmjs.com/advisories/525

`request` CHANGELOG:
https://github.com/request/request/blob/master/CHANGELOG.md#v2830-20170927
@MatthewHerbst
Copy link
Author

@MatthewHerbst MatthewHerbst commented Dec 8, 2018

@kevinegami any chance you could take a look at this please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.