Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unintentional interpretation of "%..." string contents as formatters. #8

Closed
josefdlange opened this issue May 8, 2016 · 8 comments

Comments

@josefdlange
Copy link

@josefdlange josefdlange commented May 8, 2016

Some of the data I log has, interspersed with it, strings that have a % in them, typically followed by some alphanumeric characters. In these cases, timber-loggly's logic ends up interpreting those as string formatters, and when it gets passed into the toJson method, everything blows up. I'm going to try some work on this to fix it shortly and see if I can yield some positive results.

tony19 added a commit that referenced this issue May 31, 2016
@tony19
Copy link
Contributor

@tony19 tony19 commented May 31, 2016

@josefdlange Does be311fd match your use case?

@josefdlange
Copy link
Author

@josefdlange josefdlange commented May 31, 2016

Looks like it to me.

@linakis
Copy link

@linakis linakis commented Oct 27, 2016

Any updates on this guys?

@mateusgrb
Copy link

@mateusgrb mateusgrb commented Jun 20, 2017

Hey @tony19, any plans to fix that soon? This is causing us issues in production.

@tony19
Copy link
Contributor

@tony19 tony19 commented Jun 23, 2017

Fixed by upgrade to Timber 4.1.2 in edf8486

@tony19 tony19 closed this Jun 23, 2017
@tony19
Copy link
Contributor

@tony19 tony19 commented Jun 24, 2017

@mateusgrb
Copy link

@mateusgrb mateusgrb commented Jun 26, 2017

@tony19 Thanks for the help. Would it be possible to upload 1.0.2 to maven/gradle? I added JARs below in addition to timber-loggly-1.0.2:

  • loggly-client-1.0.3
  • retrofit-1.9.0
  • gson-2.3.1

That got my project compiled and builded, but upon running no logs are sent to loggly. As it works when I use timber-loggly-1.0.1 via gradle, I believe it's a dependency issue, so being able to use it via Gradle would help tons!

@mateusgrb
Copy link

@mateusgrb mateusgrb commented Jun 27, 2017

Nevermind, I managed to get 1.0.2 working using JitPack. The logs were actually being sent but without the tags. I learned that in this version you need to call the tag() method on LogglyTree and not on Timber anymore. Would be nice to have the README updated to reflect those changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.