Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Handle unintentional interpretation of "%..." string contents as formatters. #8
Comments
|
@josefdlange Does be311fd match your use case? |
|
Looks like it to me. |
|
Any updates on this guys? |
|
Hey @tony19, any plans to fix that soon? This is causing us issues in production. |
|
Fixed by upgrade to Timber 4.1.2 in edf8486 |
|
@tony19 Thanks for the help. Would it be possible to upload 1.0.2 to maven/gradle? I added JARs below in addition to timber-loggly-1.0.2:
That got my project compiled and builded, but upon running no logs are sent to loggly. As it works when I use timber-loggly-1.0.1 via gradle, I believe it's a dependency issue, so being able to use it via Gradle would help tons! |
|
Nevermind, I managed to get 1.0.2 working using JitPack. The logs were actually being sent but without the tags. I learned that in this version you need to call the tag() method on LogglyTree and not on Timber anymore. Would be nice to have the README updated to reflect those changes! |
Some of the data I log has, interspersed with it, strings that have a
%in them, typically followed by some alphanumeric characters. In these cases,timber-loggly's logic ends up interpreting those as string formatters, and when it gets passed into thetoJsonmethod, everything blows up. I'm going to try some work on this to fix it shortly and see if I can yield some positive results.The text was updated successfully, but these errors were encountered: