Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Updated to Timber.Tree #3
Conversation
varshneyjayant
commented
Aug 12, 2015
|
1. Timber.HollowTree was deprecated 2. Added support for Appname
| @@ -193,7 +250,7 @@ private String toJson(Level level, String message, Throwable t, Object... args) | |||
| * @param t throwable | |||
| * @param args message formatting arguments | |||
| */ | |||
| private void log(Level level, String message, Throwable t, Object... args) { | |||
| private void log(int level, String message, Throwable t, Object... args) { | |||
mostlyjason
Aug 20, 2015
@psquickitjayant why change from Level to int?
@psquickitjayant why change from Level to int?
This comment has been minimized.
This comment has been minimized.
tony19
commented on src/main/java/com/github/tony19/timber/loggly/LogglyTree.java in 846945a
Aug 22, 2015
|
Instead of breaking out the |
This comment has been minimized.
This comment has been minimized.
tony19
commented on src/main/java/com/github/tony19/timber/loggly/LogglyTree.java in 846945a
Aug 22, 2015
|
The existing API (where the tag is a separate function call) follows the Timber pattern more closely, and I'd like to keep it that way unless there's a compelling reason to change. |
This comment has been minimized.
This comment has been minimized.
tony19
commented on src/main/java/com/github/tony19/timber/loggly/LogglyTree.java in 846945a
Aug 22, 2015
|
Adding |
This comment has been minimized.
This comment has been minimized.
tony19
commented on src/main/java/com/github/tony19/timber/loggly/LogglyTree.java in 846945a
Aug 22, 2015
|
Update comment to match new function API |
This comment has been minimized.
This comment has been minimized.
tony19
commented on src/main/java/com/github/tony19/timber/loggly/LogglyTree.java in 846945a
Aug 22, 2015
|
remove comment |
|
@tony19 We have improved the usage of |
|
Removed extra code for |
|
Do you want a separate PR as feature update for |
|
updated comments. |
| @@ -53,6 +54,43 @@ public LogglyTree(String token) { | |||
| handler = new LogglyClient.Callback() { | |||
| @Override | |||
| public void success() { | |||
|
What do we need to do to get a new version of Timber supported? I can take over this PR if necessary. |
|
@darren-kelinske-fivestars Please go ahead and raise a PR. Also, please directly contact the loggly github page. Thanks, Jayant. |