Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fallback behavior for inadvertent string formatters in log messages #9
Conversation
|
Bumping my own PR -- hope you see this and can merge it in. |
|
Sorry for the late reply. This patch is obviated by my upcoming changes (not yet published), where I've upgraded to the newest Timber release, which handles arg-formatting before it even gets to the Timber client. I'll create a unit test for this bug. I'll close this issue once I merge. |
|
Handled in timber-loggly-1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #8
If we get a
java.util.MissingFormatArgumentException, we just throw the message to the logger as-is and forget about trying to format any args into it. It's suboptimal behavior if you actually passed format arguments, but also it doesn't crash the app in the converse case.