Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message lost during logging #29

Closed
lionello opened this issue Dec 6, 2017 · 2 comments
Closed

Error message lost during logging #29

lionello opened this issue Dec 6, 2017 · 2 comments

Comments

@lionello
Copy link

@lionello lionello commented Dec 6, 2017

This line https://github.com/loggly/winston-loggly-bulk/blob/master/lib/winston-loggly.js#L122 overwrites any field message in the meta object. When meta is an instanceof Error, this effectively replaces the error message from the object with an empty string.

A quick fix could be to do

  message.message = msg || message.message;
@mostlyjason
Copy link

@mostlyjason mostlyjason commented Dec 6, 2017

Thanks for reporting this! We will have one of our engineers take a look

@Shwetajain148
Copy link

@Shwetajain148 Shwetajain148 commented Mar 28, 2018

Hi @lionello, Since this issue has been handled in the winston-loggly-bulk's 2.0.2 release, I am going ahead and closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.