Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"winston" should be a peerDependency not a dependency? #57

Open
mhintzke opened this issue Nov 20, 2019 · 0 comments
Open

"winston" should be a peerDependency not a dependency? #57

mhintzke opened this issue Nov 20, 2019 · 0 comments

Comments

@mhintzke
Copy link

@mhintzke mhintzke commented Nov 20, 2019

I'm still fairly inexperienced with how these should work but since winston-loggly-bulk is an extension package to the winston package, a consumer of this package should already have winston installed. I believe when this situation occurs, the use of peerDependencies is favored over dependencies.

Please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.