Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
include timestamp in nodejs events #14
Merged
+1
−1
Conversation
Shwetajain148
changed the title
| @@ -58,7 +58,7 @@ var Loggly = exports.Loggly = function (options) { | |||
| bufferOptions: options.bufferOptions || {size: 500, retriesInMilliSeconds: 30 * 1000} | |||
| }); | |||
|
|
|||
| this.timestamp = options.timestamp || false; | |||
mchaudhary
Mar 28, 2017
@Shwetajain148 this means that timestamp is always true even if options contain it as false. The behavior we implement is by default it is true and if user specify it as false then we keep it false.
@Shwetajain148 this means that timestamp is always true even if options contain it as false. The behavior we implement is by default it is true and if user specify it as false then we keep it false.
Shwetajain148
Mar 29, 2017
Author
Thanks @mchaudhary for the feedback.
I have updated the condition to set the timestamp by default and also to set it to false if user specify it explicitly.
I've covered below conditions,:
User's Input explicitly
Timestamp field in the log event
true
Yes
false
No
Not set
Yes
anything except false boolean
Yes
Thanks @mchaudhary for the feedback.
I have updated the condition to set the timestamp by default and also to set it to false if user specify it explicitly.
I've covered below conditions,:
| User's Input explicitly | Timestamp field in the log event |
|---|---|
| true | Yes |
| false | No |
| Not set | Yes |
anything except false boolean |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.