Skip to content

/ winston-loggly-bulk

forked from winstonjs/winston-loggly
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include timestamp in nodejs events #14

Merged
merged 2 commits into from Mar 29, 2017
+1 −1
Merged

include timestamp in nodejs events #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7af4f
incude timestamp in nodejs events
Mar 28, 2017
e8f39b8
set timestamp field true by default and also make it configurable
Mar 29, 2017
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

2 lib/winston-loggly.js
View file
Open in desktop
@@ -58,7 +58,7 @@ var Loggly = exports.Loggly = function (options) {
bufferOptions: options.bufferOptions || {size: 500, retriesInMilliSeconds: 30 * 1000}
});

this.timestamp = options.timestamp || false;

This comment has been minimized.

Sign in to view
@mchaudhary

mchaudhary Mar 28, 2017

@Shwetajain148 this means that timestamp is always true even if options contain it as false. The behavior we implement is by default it is true and if user specify it as false then we keep it false.

This comment has been minimized.

Sign in to view
@Shwetajain148

Shwetajain148 Mar 29, 2017
Author

Thanks @mchaudhary for the feedback.

I have updated the condition to set the timestamp by default and also to set it to false if user specify it explicitly.

I've covered below conditions,:

User's Input explicitly Timestamp field in the log event
true Yes
false No
Not set Yes
anything except false boolean Yes
this.timestamp = options.timestamp === false ? false : true;
this.stripColors = options.stripColors || false;
};

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.