Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
pass loggly http client errors to winston continuation #4
Conversation
…opagated up correctly and can be consumed by end users
|
@Shwetajain148 can you review when you get a chance? Seems like a small change. |
|
@mchaudhary, @mostlyjason I have tested this PR at my end and it seems to work fine so kindly merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Background: in the case of a failed attempt to post a message to Loggly, it'd be nice to be able to detect the failure via Winston's
log()callback param and respond accordingly (write to file, write to console, etc).I was perplexed to discover that HTTP errors in the Loggly client don't result in an error being passed back up to continuation functions supplied to winston's
log()method, and upon reading the source, it appeared to be a simple oversight.This single commit enables the expected behavior.