Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Create new npm package #5
Merged
Conversation
-rename package name to 'loggly-bulk' -update package version to 1.0.4 as it is new package -add loggly, winston keywords -update author details
| @@ -81,7 +81,7 @@ Once you have valid configuration and credentials you can run tests with [npm][7 | |||
| npm test | |||
| ``` | |||
|
|
|||
| #### Author: [Charlie Robbins](http://blog.nodejitsu.com) | |||
| #### Author: [Shweta Jain](https://www.loggly.com/) | |||
mchaudhary
Oct 15, 2016
Should we change name ? @mostlyjason thoughts ?
Should we change name ? @mostlyjason thoughts ?
mostlyjason
Oct 17, 2016
Sure we can update it or you can add a 2nd line
Sure we can update it or you can add a 2nd line
Shwetajain148
Oct 19, 2016
•
Author
@mchaudhary @mostlyjason I have made changes in the README.md file as per our discussion on author name. Please review..
@mchaudhary @mostlyjason I have made changes in the README.md file as per our discussion on author name. Please review..
| "description": "A Loggly transport for winston", | ||
| "author": "Charlie Robbins <charlie.robbins@gmail.com>", | ||
| "author": "Shweta Jain <sjain@loggly.com>", |
mchaudhary
Oct 15, 2016
same here?
same here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As we have to create new npm package. Below are the changes that are done in this PR.
-update package version
-update author details
-update README.md reference
Created Package link: loggly-winston-bulk.