Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Append log splats to Loggly message object #58
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hello there!
After moving over to Winston 3 from Winston 2, I noticed that Winston was now appending all extra logging arguments as "Symbol(splats)" in the final "message" log object.
Specific actions have to be taken in order to forward those splats to Loggly, as extra arguments are not anymore being forwarded to Loggly.
Depending on the logging pattern in a project, splats could contain an Error object, a plain JS object, or a string message. For instance, calling
log.error("An error occured:", new Error("Nah!"))would set "An error occured:" asmessage.message, but would not forward theErrorobject to Loggly. This PR addresses this "regression" after an upgrade from Winston 2 to 3.Notice:
splatsis an array of all extra values passed to the logging function. Providing 4 arguments to the logging call would induce a splats object of length 3.