Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-8039 update packages #59

Merged
merged 18 commits into from Apr 6, 2020
Merged

LOG-8039 update packages #59

merged 18 commits into from Apr 6, 2020

Conversation

@alestrunda
Copy link

@alestrunda alestrunda commented Mar 25, 2020

update packages, readme, code format

@alestrunda alestrunda requested a review from loggly/lg2-devs Mar 25, 2020
Copy link

@michal-bures michal-bures left a comment

Noticed a few issues, but otherwise seems ok, was able to run the tests and see results in loggly.

Don't forget to remove the alpha version from package.json before merge (and best not to merge before we verify the functionality in portal).

The automated tests don't give me too much confidence (as illustrated by the two issues I found in code which didn't break any of them), but expanding them is a topic for another task.

lib/winston-loggly.js Outdated Show resolved Hide resolved
lib/winston-loggly.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link

@michal-bures michal-bures left a comment

Looks good, don't forget to remove alpha2 from package.json before merging 🙂.

@alestrunda alestrunda force-pushed the LOG-8039-update branch from 9fad3a3 to fe043c6 Apr 3, 2020
@alestrunda alestrunda force-pushed the LOG-8039-update branch from fe043c6 to 65d4270 Apr 3, 2020
@alestrunda alestrunda merged commit 2542c24 into master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.