Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-8039 update packages #59

Merged
merged 18 commits into from Apr 6, 2020

use lodash.clonedeep instead of clone

  • Loading branch information
alestrunda committed Apr 2, 2020
commit 644466dd39e69947f5321158d803db58592d0895
@@ -6,7 +6,7 @@
*
*/

var clone = require('clone'),
var cloneDeep = require('lodash.clonedeep'),
loggly = require('node-loggly-bulk'),
util = require('util'),
winston = require('winston'),
@@ -102,7 +102,7 @@ const validateMetadata = meta => {
} else if (typeof meta !== 'object') {
return { metadata: meta };
} else {
return clone(meta);
return cloneDeep(meta);
}
};

Some generated files are not rendered by default. Learn more.

@@ -28,7 +28,7 @@
"winston"
],
"dependencies": {
"clone": "^2.1.2",
"lodash.clonedeep": "^4.5.0",
"node-loggly-bulk": "^2.2.4",
"winston": "^3.2",
"winston-transport": "^4.3.0"
This conversation was marked as resolved by michal-bures

This comment has been minimized.

@michal-bures

michal-bures Mar 26, 2020

These two should really really be in peer dependencies, we shouldn't force users to use our chosen version of winston... But moving it there can break stuff for existing users which will now have to add the winston dependency manually... Let's make a separate task for that.

This comment has been minimized.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.