Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support of the weekdays in Dates #5421

Open
elkrause opened this issue May 24, 2022 · 13 comments
Open

i18n support of the weekdays in Dates #5421

elkrause opened this issue May 24, 2022 · 13 comments
Labels
estimate: large Require major refactor of a feature i18n :type/enhancement Enhancement to product. Does not affect the overall basic use.

Comments

@elkrause
Copy link

What happened?

Hi! I have changed to German language in the editor settings, but still the day of the week in the journal is in English. Also when I select a date with the date picker the day name is in English.

Reproduce the Bug

Just open the editor

Expected Behavior

I would expect the German names of the weekdays (Montag, Dienstag, ...)

Screenshots

2022-05-24_22h11_20

2022-05-24_22h11_26

Desktop Platform Information

Windows 10, Logseq 0.7.0

Mobile Platform Information

iOS 15.5, Logseq 0.6.9

Additional Context

No response

@andelf andelf added i18n :type/bug Something isn't working. Affects daily use. labels May 25, 2022
@ingepettersen
Copy link
Contributor

AFAIK this isn't a translation error, but rather a restriction in what can be translated. The translation-files doesn't support translating how weekday names are rendered.

I've translated Logseq to Norwegian, and the same issue is present there. I would also like this to be possible, so I hope the devs can provide some insight and what plans they have to support more complete translations.

@eldelacajita
Copy link

Supporting this issue. It would be great to be able to translate the weekday names.

@hellpe
Copy link

hellpe commented Mar 6, 2023

Since I've received an email warning me that the issue would be automatically closed in 20 days without activity, I'm leaving a me-too comment to confirm that I'm still having this issue using the French translation on Logseq (Flathub version on Fedora Silverblue 37).

@Bad3r Bad3r changed the title Error in German translation in date title Translate Dates Mar 6, 2023
@bogenschlag
Copy link

bogenschlag commented Apr 21, 2023

Translated weekdays would indeed be highly appreciated, especially after dd.MM.yyyy as sane, simple European date format apparently was lost to some Clojure library bug.

@cnrpman cnrpman added :type/enhancement Enhancement to product. Does not affect the overall basic use. and removed :type/bug Something isn't working. Affects daily use. labels May 24, 2023
@cnrpman
Copy link
Collaborator

cnrpman commented May 24, 2023

@bogenschlag The buggy case happens when using dd.MM.yyyy to parse other date formats. The rule is just too "wide".

There should be some work-around. Investigation is welcome.

I would suggest allowing customize the formatter for display (timestamp -> string for display) only, to avoid the parsing issue.

@cnrpman cnrpman added the estimate: large Require major refactor of a feature label May 24, 2023
@cnrpman cnrpman changed the title Translate Dates i18n support of the weekdays in Dates Jun 4, 2023
@einmeterhecht
Copy link
Contributor

einmeterhecht commented Jul 25, 2023

Is there already a separate issue for changing the format of dates and translating the months' names, especially in journals?

@cnrpman
Copy link
Collaborator

cnrpman commented Aug 8, 2023

@einmeterhecht no other ticket AFAIK
Feel free to link here if you found any

@moshpirit
Copy link

I don't understand exactly the issue, wouldn't be a way to "add" a string before the date?

I think there's a plugin that adds a calendar icon, maybe there could be a script that adds the weekday following some rule (if weekday of {date} is X, then show this word). Why is this so hard to implement?

@elkrause
Copy link
Author

The issue is that weekdays before the dates in the daily log are always written in English no matter what Logseq language is set.

I guess it is only seen by non English Logseq users 🙃

@andelf
Copy link
Collaborator

andelf commented Jan 19, 2024

Sorry for any inconvenience caused, @elkrause.

Some changes need to be made in the underlying part as "date link text" should also be written in the corresponding language/format.

JavaScript has a nice data API, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat#examples . It supports almost any date format from any calendar.

Another approach is to split the display date and storage date. CC @xyhp915

@bmxp
Copy link

bmxp commented Apr 1, 2024

Hm. IMHO it is essential to have native language support in such an key software as logseq. Please implement a proper language handling for dates in journal soon.

@punkyard
Copy link

punkyard commented Apr 2, 2024

thank you @jn64

the thread title should include "days of the week"
"weekdays" means days from Monday to Friday

@kauesena
Copy link

As a non-native english speaker, I do also believe it to be an essential feature the option of displaying the names for the days of the week in the user's respective language.

the thread title should include "days of the week" "weekdays" means days from Monday to Friday

And I do agree with @punkyard. Seeking this issue, I searched precisely for "days of the weak", but to no avail. (It then ocurred me to look for "weekday".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate: large Require major refactor of a feature i18n :type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
Status: 🗄 Backlog
Development

No branches or pull requests