Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whiteboards] Text with colon pasted as URL #7018

Closed
pstuifzand opened this issue Oct 18, 2022 · 2 comments
Closed

[whiteboards] Text with colon pasted as URL #7018

pstuifzand opened this issue Oct 18, 2022 · 2 comments
Labels
editor:copy-paste Clipboard data attached is appreciated. See menu - bug report - clipboard inspector 🎨 :feat/whiteboard

Comments

@pstuifzand
Copy link
Contributor

What happened?

The isValidURL function validates pieces of pasted text as urls, when it really should be text.

I pasted Was: x becomes y as text from a text document on a whiteboard and a "browser" shape was created, when it should have been a whiteboard block. I also pressing shift at the same time, but that also created an iframe. Also dragging from the text editor created an iframe.

Reproduce the Bug

  1. Open a whiteboard
  2. Type "was: x becomes y" in a text editor
  3. Copy the text, or drag to text to the whiteboard
  4. An iframe shape is created

Expected Behavior

It should create a whiteboard text block

Screenshots

image

Desktop Platform Information

Linux Ubuntu 20.04.
Logseq 0.8.8+nightly20221017

Mobile Platform Information

No response

Additional Context

No response

@cnrpman cnrpman added the editor:copy-paste Clipboard data attached is appreciated. See menu - bug report - clipboard inspector label Oct 18, 2022
@pstuifzand
Copy link
Contributor Author

I have tested this with 0.8.15.

  • Dragging text to the whiteboard does not create an iframe anymore.
  • Copy paste of the same text DOES create an iframe.

@sprocketc
Copy link
Collaborator

Handled here #8753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor:copy-paste Clipboard data attached is appreciated. See menu - bug report - clipboard inspector 🎨 :feat/whiteboard
Projects
Archived in project
Development

No branches or pull requests

4 participants