fix(test): removal of select-all shortcut #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
force-pushed
the
fix/e2e-select-all-change
branch
from
ed0865b
to
3bd4ad3
Compare
andelf
commented
Dec 30, 2022
| @@ -953,7 +953,7 @@ Similar to re-frame subscriptions" | |||
| (set-selection-blocks! blocks :down)) | |||
| ([blocks direction] | |||
| (when (seq blocks) | |||
| (let [blocks (util/sort-by-height blocks)] | |||
| (let [blocks (util/sort-by-height (remove nil? blocks))] | |||
There was a problem hiding this comment.
Avoids:
Uncaught TypeError: Cannot read properties of null (reading 'getBoundingClientRect')
at Object.frontend$util$get_dom_top [as get_dom_top]
tiensonqin
changed the title
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod+ais now registered as a global shortcut.Releated #7803
Bug1:
mod+awill ignore current editing status and select page blocksBug2:
mod+awill cause error: