fix(e2e-test): should not wait for selector when there is no onboarding button #8212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found when I want to perform a single e2e test instead of all.
If we test just a single e2e test in debug mode(both debug and non-debug mode fails, debug mode is just used to
demonstrate how I found where the bug occurs), the test will be failed and we will be breaked at this line.
Here is screen recording.
Kapture.2023-01-04.at.13.51.48.mp4
I have also found that the test dir is loaded by these codes so that simply clicking on
Add new graph
will automatically load the test graph.logseq/e2e-tests/utils.ts
Lines 148 to 161 in 86b5c9d
logseq/src/main/frontend/util.cljc
Lines 119 to 123 in 86b5c9d
After fixing this bug.
Kapture.2023-01-04.at.13.57.32.mp4