Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit cache is synchronised, making concurrent lookups impossible #35

Closed
noofherder opened this Issue Aug 18, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@noofherder
Copy link

noofherder commented Aug 18, 2017

Logstash version 5.5.1

Enabling the cache reduces dns performance, while a hacked version with no synchronisation has better performance.

Full details here: http://www.flax.co.uk/blog/2017/08/17/better-performance-logstash-dns-filter/

@ph ph self-assigned this Sep 8, 2017

@ph

This comment has been minimized.

Copy link
Contributor

ph commented Sep 8, 2017

By looking at the blog post, it make sense that you have better performance without the lock.
I need to take a look at the LRU implementation, the other thing that could be slow is the block creation on every request.

We will have to profile that.

If the LRU is blocking the whole structure for a check or an update, this is not optimal.

@andrewvc

This comment has been minimized.

Copy link
Contributor

andrewvc commented Mar 9, 2018

This should be fixed now that we use LRU::Redux for the cache

@andrewvc andrewvc closed this Mar 9, 2018

@andrewvc

This comment has been minimized.

Copy link
Contributor

andrewvc commented Mar 9, 2018

I misread this, reopening.

@andrewvc andrewvc reopened this Mar 9, 2018

@jsvd

This comment has been minimized.

Copy link
Contributor

jsvd commented May 14, 2018

this has been resolved with #42

@jsvd jsvd closed this May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.