Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out mysql for postgresql for testing #11

Closed
wants to merge 3 commits into from

Conversation

@robbavey
Copy link
Contributor

robbavey commented May 10, 2018

No description provided.

@robbavey robbavey force-pushed the robbavey:use_postgresql branch from 8d30596 to 03f9047 May 10, 2018
@robbavey robbavey force-pushed the robbavey:use_postgresql branch from 03f9047 to 2243f75 May 10, 2018
@elasticsearch-bot elasticsearch-bot self-assigned this May 11, 2018
@@ -10,13 +10,13 @@ class TestJdbcStreaming < JdbcStreaming
end

describe JdbcStreaming, :integration => true do
# Use MySql for integration tests
::Jdbc::MySQL.load_driver
# Use MariaDB for integration tests

This comment has been minimized.

Copy link
@jakelandis

jakelandis May 11, 2018

Contributor

MairaDB is a fork of Mysql , did you mean Postgres ?

This comment has been minimized.

Copy link
@robbavey

robbavey May 11, 2018

Author Contributor

D'oh, my first choice to switch out was MariaDB, but changed to Postgres for the more forgiving license, but didn't change the comment - good catch

@jakelandis jakelandis self-requested a review May 11, 2018
@jakelandis

This comment has been minimized.

Copy link
Contributor

jakelandis commented May 11, 2018

one minor correction to the comments. LGTM

I have to ask... why change ? (without starting a flame war :) )

@robbavey

This comment has been minimized.

Copy link
Contributor Author

robbavey commented May 11, 2018

@jakelandis Thanks for the LGTM - the intent was to remove a GPL licensed dependency. While we don't ship the jdbc-mysql gem (its only used in testing), removing it reduces any ambiguity in this area

@elasticsearch-bot

This comment has been minimized.

Copy link

elasticsearch-bot commented May 11, 2018

Rob Bavey merged this into the following branches!

Branch Commits
master 27722c8, 070688a, 02760dc
elasticsearch-bot pushed a commit that referenced this pull request May 11, 2018
elasticsearch-bot pushed a commit that referenced this pull request May 11, 2018
Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.