Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logstash 7 compatible #10

Closed
wants to merge 4 commits into from
Closed

Conversation

@rklomp
Copy link
Contributor

rklomp commented May 31, 2019

Fix for #9

rklomp added 4 commits May 31, 2019
@yaauie yaauie self-assigned this Jun 13, 2019
@yaauie

This comment has been minimized.

Copy link
Contributor

yaauie commented Jun 13, 2019

It looks like we have a bit of a dependency tangle, since public_suffix >= 3 requires a ruby runtime of 2.1, but Logstash 5.x runs with ruby 1.9.x.

I'll assign this to myself and see if I can chase down something in the next week or two that will work for modern Logstashes without explicitly breaking behaviour on Logstash 5.x.

@SpencerLN

This comment has been minimized.

Copy link

SpencerLN commented Nov 7, 2019

@yaauie Did you have any luck finding a way to correct this without breaking 5.x? If not, would it make sense to accept this PR so that those using more recent versions of Logstash can take advantage of the plugin?

@jsvd

This comment has been minimized.

Copy link
Contributor

jsvd commented Nov 7, 2019

fixed in f4963b2

@jsvd jsvd closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.