Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too_long_frame_excepton by passing scroll_id in the body #159

Closed
wants to merge 1 commit into from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 11, 2021

This fixes #141.

(This is a simple change and should work as intended, but I seldom use Ruby so please verify!)

This should resolve the `too_long_frame_exception` issue described in #141.
Copy link
Contributor

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested manually and confirmed the delete request is sent correctly.
I created #161 to carry this PR forward by adding the necessary release cruft so we can publish this change.
I'll close this in favor of #161, commit authorship is preserved. thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing a scroll occasionally raises a 'too_long_frame_exception'
3 participants