Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also clone default codec #80

Merged

Conversation

Projects
None yet
3 participants
@colinsurprenant
Copy link
Contributor

commented Mar 21, 2018

Fixes #79

This PR simply support also cloning the default codec. The current specs does test the codec support so I do not believe more specs are required for this specific case which result in a thread safety issue and is hard to test per-se.

@jsvd

jsvd approved these changes Mar 22, 2018

Copy link
Contributor

left a comment

LGTM

@jsvd

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2018

I see a few failures of builds timing out, but that is happening in master as well.

@colinsurprenant

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2018

@jsvd is certainly not related, but I'll restart it anyway to see.

@colinsurprenant

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2018

so yeah, still failing. I am confident these are not related so will go ahead and merge. - I am another Pr incoming for calling flush so I will defer the publishing to the next PR.

@colinsurprenant colinsurprenant merged commit 387f0b6 into logstash-plugins:master Mar 22, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
CLA Commit author is a member of Elasticsearch
Details

This was referenced Mar 22, 2018

@colinsurprenant colinsurprenant added the bug label Mar 22, 2018

@colinsurprenant

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2018

this has been released in v3.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.