Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change doc to show that schedule is a required option #102

Merged
merged 1 commit into from Oct 25, 2018

Conversation

@karenzone
Copy link
Contributor

karenzone commented Oct 24, 2018

Customer (and support) pointed out apparent error in doc:
"The Logstash http_poller input plugin indicates the param for schedule as No for required. Description for this param explicitly states there is no default value for this setting, and that it dictates "when to periodically poll from the urls," which implies it IS in fact required. When attempting to use this plugin without the schedule param, Logstash produces the error:

[2018-10-22T11:45:13,334][ERROR][logstash.inputs.http_poller] Missing a required setting for the http_poller input plugin:

input {
http_poller {
schedule => # SETTING MISSING
...
}
}
We should update docs to reflect that this setting is required."

elastic/docs#443

@karenzone karenzone force-pushed the karenzone:schedule-required branch from 60d0411 to 6d32d19 Oct 24, 2018
@jsvd
jsvd approved these changes Oct 25, 2018
Copy link
Contributor

jsvd left a comment

LGTM

@jsvd jsvd merged commit 469f190 into logstash-plugins:master Oct 25, 2018
2 checks passed
2 checks passed
CLA Commit author is a member of Elasticsearch
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.