Logstash 5.x Compatibility #26

Closed
krisko opened this Issue Oct 24, 2016 · 9 comments

Projects

None yet

8 participants

@krisko
krisko commented Oct 24, 2016

Hi,
I'm getting an error message when trying to install this plugin for rc1 release.

  • Version: 5.0.0-rc1
  • Steps to Reproduce: ./bin/logstash-plugin install --no-verify logstash-input-jmx
  • Error Msg:
    ERROR: Installation Aborted, message: Bundler could not find compatible versions for gem "logstash-core-plugin-api":
    In snapshot (Gemfile.lock):
    logstash-core-plugin-api (= 2.1.16)
    ...
@nothau
nothau commented Oct 28, 2016 edited

@I tried to force it in by updating the version restriction in logstash-input-jmx.gemspec

From:

  • s.add_runtime_dependency "logstash-core-plugin-api", ">= 1.60", "<= 2.9.9"

To:

  • s.add_runtime_dependency "logstash-core-plugin-api", ">= 1.60", "<= 5.0.0"

But ran into an error when actually parsing through the jmx data it recieved (from cassandra 3.0):
undefined methodevent' for #LogStash::Inputs::Jmx:0x4128d182`

[2016-10-28T20:39:22,744][WARN ][logstash.inputs.jmx ] Failed retrieving metrics for attribute object_name on object java.nio:type=BufferPool,name=mapped
[2016-10-28T20:39:22,744][WARN ][logstash.inputs.jmx ] undefined method `event' for #LogStash::Inputs::Jmx:0x4128d182

@untergeek
untergeek commented Oct 28, 2016 edited

I'm guessing it's because these lines should read event.set( and not event(

https://github.com/logstash-plugins/logstash-input-jmx/blob/master/lib/logstash/inputs/jmx.rb#L175-L177

Since event.set is a method, but not event.

@nothau
nothau commented Oct 31, 2016

That was it, working now.

@talevy
Contributor
talevy commented Nov 8, 2016

fixed by latest commit and published as version 3.0.0

@talevy talevy closed this Nov 8, 2016
@boernd
Contributor
boernd commented Nov 9, 2016

@talevy I think you forgot to apply the fix mentioned above? Issue still present in 3.0.0

@boernd boernd referenced this issue Nov 11, 2016
Merged

Fix event api bug #27

@mrosterm
mrosterm commented Dec 2, 2016

I think @boernd might be right. I'm also having issues with 3.0.0 being broken. @talevy please release a new build 😄

@diedirk
diedirk commented Dec 6, 2016

+1 Will be great to get a new release

@krizsan
krizsan commented Dec 6, 2016

+1

@talevy talevy referenced this issue Jan 10, 2017
Merged

bump fix to 3.0.1 #33

@talevy
Contributor
talevy commented Jan 10, 2017

@diedirk @krizsan @mrosterm @boernd, published version 3.0.1 with #27, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment