Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 support. #31

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@jordansissel
Copy link
Contributor

commented Nov 13, 2017

In Logstash 5.x and below, JRuby 1.7.x is used, and
UDPSocket.new(Socket::AF_INET) somehow accidentally works with IPv6.

Logstash 6.x uses JRuby 9.x where this now behaves correctly (AF_INET is
ipv4 only), but triggers a bug where ipv6 was accidentally disabled in
the udp input. Oops!

This change is small (AF_INET -> AF_INET6) and adds tests to cover the
default scenario that 127.0.0.1 and ::1 both work for the default.

@duylong

This comment has been minimized.

Copy link

commented Jan 19, 2018

Missing in the master branch.

@jsvd jsvd force-pushed the feature/ipv6 branch from a63d208 to a45fd1a Mar 20, 2018

@jsvd jsvd self-assigned this Mar 20, 2018

@jsvd jsvd added the bug label Mar 20, 2018

@jsvd jsvd force-pushed the feature/ipv6 branch from a45fd1a to 698c778 Mar 20, 2018

Fix IPv6 support.
In Logstash 5.x and below, JRuby 1.7.x is used, and
UDPSocket.new(Socket::AF_INET) somehow accidentally works with IPv6.

Logstash 6.x uses JRuby 9.x where this now behaves correctly (AF_INET is
ipv4 only), but triggers a bug where ipv6 was accidentally disabled in
the udp input. Oops!

This change is small and adds tests to cover the
default scenario that 127.0.0.1 and ::1 both work for the default.

@jsvd jsvd force-pushed the feature/ipv6 branch from 698c778 to e1889e9 Mar 20, 2018

@jsvd jsvd merged commit 79dd734 into master Mar 20, 2018

3 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ruben-herold ruben-herold referenced this pull request Apr 3, 2018

Closed

Add Ipv6 Listeners #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.