Feat: name scheduler threads + redirect error logging #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- redirecting potential logs to LS logger - setting thread name for scheduler threads - any worker threads started are also named
kares
commented
Jan 17, 2022
| # Rufus::Scheduler >= 3.4 moved the Time impl into a gem EoTime = ::EtOrbi::EoTime` | ||
| # Rufus::Scheduler 3.1 - 3.3 using it's own Time impl `Rufus::Scheduler::ZoTime` | ||
| TimeImpl = defined?(Rufus::Scheduler::EoTime) ? Rufus::Scheduler::EoTime : | ||
| (defined?(Rufus::Scheduler::ZoTime) ? Rufus::Scheduler::ZoTime : ::Time) |
There was a problem hiding this comment.
for now LS is locked to rufus-scheduler 3.0.9 but this is compatible with any version >= 3.0.9
(there's an upgrade pending at: #97)
andsel
approved these changes
Jan 19, 2022
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of the work here is to avoid
STDERR.putsfromRufus::Scheduler#on_erroras well asto set a
Thread#name(which than sets Java thread name) for threads started by rufus-scheduler.Threads started by a particular plugin will use a common prefix - making them identifiable from Java thread dumps:
[#{id}]<jdbc__scheduleris used for the scheduler thread[#{id}]<jdbc__scheduler_worker-00will be the name of the first started worker threadNOTE: extracted from #97